[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

Alex Voicu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 17 05:58:31 PDT 2023


AlexVlx added a comment.

In D150746#4349408 <https://reviews.llvm.org/D150746#4349408>, @aaron.ballman wrote:

> Thank you for the fix! Please be sure to add test coverage for the changes and a release note for the fix.
>
> Adding the codegen code owners for review. FWIW, precommit CI is failing to build the patch.

Thank you and apologies for the noise. I will add test coverage (shied away from doing it as I ran into this in a fairly oblique context, but turns out there are some existing tests that hit pretty close to home and I'll start from those).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150746/new/

https://reviews.llvm.org/D150746



More information about the cfe-commits mailing list