[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 17 05:26:39 PDT 2023


aaron.ballman added a comment.

In D149677#4320178 <https://reviews.llvm.org/D149677#4320178>, @li.zhe.hua wrote:

> In D149677#4319646 <https://reviews.llvm.org/D149677#4319646>, @aaron.ballman wrote:
>
>> Will this new printing policy be used in tree?
>
> Not initially, no. (I'm understanding "in tree" as "in the LLVM project".)

You understand correctly. :-)

> Some additional context: I'm working on a refactoring tool to, in part, deprecate an alias by replacing it with its definition. That functionality by itself could be provided through something like a clang-tidy, so I say "initially".

We typically don't add new printing policies in tree without some need for them in the project itself (otherwise this becomes a maintenance problem), and I'm not certain I see a strong need for this to live in Clang. I think it might be best to wait until you're closer to having a clang-tidy check that would use this functionality before we continue with this patch. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149677/new/

https://reviews.llvm.org/D149677



More information about the cfe-commits mailing list