[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

Tue May 16 23:50:16 PDT 2023

kiranchandramohan added a comment.

In D150354#4342146 <https://reviews.llvm.org/D150354#4342146>, @domada wrote:

> In D150354#4337148 <https://reviews.llvm.org/D150354#4337148>, @awarzynski wrote:
>
>> All in all LGTM, but I'm not sure whether Flang should be defaulting to OpenMP 5.0. AFAIK, that's not supported yet.
>
> If you wish I can set to OpenMP 4.5. But then we need to have two separate flags in clang/include/clang/Driver/Options.td (one for clang and the second one for flang).

We will not be able to match the OpenMP support in clang (stand support level) soon. Although we have made lot of progress, we are effectively around 1.1. To stay true to the meaning of this metadata, we will have to have separate flags. But, I guess, `fclang-openmp-version` might not be acceptable to Clang folks who are used to using `-fopenmp-version`. Can't this be achieved by the same flag? On a cursory look, i don't see anything that prevents using the same flag but with different defaults in the code that is handling the flag.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150354/new/

https://reviews.llvm.org/D150354