[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

Yueh-Ting (eop) Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 16 23:39:50 PDT 2023


eopXD added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:3070
+
+          llvm::Value *LoadedStructValue = CreateCoercedLoad(Ptr, STy, *this);
+
----------------
craig.topper wrote:
> What are we loading here?
> 
> Is there a test for this code?
You are right, should be a poison here.

Test case `clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/rvv-tuple-type-0.c` and `clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/rvv-tuple-type-1.c` covers the code here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146873/new/

https://reviews.llvm.org/D146873



More information about the cfe-commits mailing list