[PATCH] D150492: [AST] Initialize local counter

Ben Barham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 16 16:44:22 PDT 2023


bnbarham accepted this revision.
bnbarham added inline comments.


================
Comment at: clang/lib/Frontend/ASTUnit.cpp:825
   HeaderSearch &HeaderInfo = *AST->HeaderInfo;
-  unsigned Counter;
 
----------------
> I assume it's optional and ReadAST does not have to set the counter on success.

Looks like we only write the counter value when it's non-zero. So the reader would never set it. Thanks for fixing!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150492/new/

https://reviews.llvm.org/D150492



More information about the cfe-commits mailing list