[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 16 13:47:45 PDT 2023


ABataev added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10490
+def warn_omp_minus_in_reduction_deprecated : Warning<
+  "minus(-) operator for reductions is deprecated; use an user defined reduction instead">,
+  InGroup<Deprecated>;
----------------
mdfazlay wrote:
> ABataev wrote:
> > `use + or user defined reudction instead`? And better make it a fixme note.
> @ABataev, Do you want me to add a warning and a note at the same location? Or Changing the warning message to `minus(-) operator for reductions is deprecated; use + or user defined reduction instead` is just fine? Please let me know which one you prefer.
Would be good to have both. But since it is a temp warning, I'm fine with your message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150394/new/

https://reviews.llvm.org/D150394



More information about the cfe-commits mailing list