[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

[Jan Sjödin via Phabricator via cfe-commits]

jsjodin added a comment.

@jdoerfert do you have any feedback?



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1882
+  auto EntryInfo = OMPBuilder.getTargetEntryUniqueInfo(
+      PLoc.getFilename(), PLoc.getLine(), VD->getName());
   SmallString<128> Buffer, Out;
----------------
This logic is duplicated  a few times, so a function would probably help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149162/new/

https://reviews.llvm.org/D149162