[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:644
+StorageLocation *Environment::getStorageLocationStrict(const Expr &E) const {
+  assert(E.isGLValue());
+  StorageLocation *Loc = getStorageLocation(E, SkipPast::None);
----------------
why does it make sense to allow setStorageLocationStrict but not getStorageLocationStrict for builtin functions?


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:703
+  assert(E.isPRValue());
+  assert(!isa<ReferenceValue>(Val));
+
----------------
this isn't documented, should it be?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150653/new/

https://reviews.llvm.org/D150653