[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

Tue May 16 05:05:50 PDT 2023

sammccall added inline comments.

================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138

+static void forwardValue(const Expr &From, const Expr &To, Environment &Env) {
+  if (auto *Val = Env.getValueStrict(From))
----------------
the name "forward" isn't clear to me - if anything suggesting std::forward, but not assignment.

Maybe `assignValue` or `copyValue`, and `aliasLocation` for the storageloc variant?

That leaves "forwardValueOrStorageLocation", but that only has one callsite and part of the point of this refactoring is that we're best thinking about these cases explicitly, right? So could just inline the if.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150655/new/

https://reviews.llvm.org/D150655