[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added inline comments.


================
Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43
 // CHECK-NEXT:               "context-hash": "{{.*}}",
-// CHECK-NEXT:               "module-name": "FW2_Private"
+// CHECK-NEXT:               "module-name": "FW2"
 // CHECK-NEXT:             }
----------------
jansvoboda11 wrote:
> benlangmuir wrote:
> > Does this lose any test coverage for the FW2_Private case?
> This still tests the same general code path, just a more specific case of it. I can keep this test as is and create new one specifically to test the "explicit submodule" case if that makes more sense to you.
Yeah, my preference would be to add a case instead of modifying this one, unless there is somewhere else we're already testing the same thing. The exact behaviour of FW2.Private vs FW2_Private vs FW2Private is all subtlely different


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150479/new/

https://reviews.llvm.org/D150479