[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers
    Jan Svoboda via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Mon May 15 11:40:38 PDT 2023
    
    
  
jansvoboda11 added inline comments.
================
Comment at: clang/lib/Serialization/ASTWriter.cpp:3646
     // file.
     SmallVector<const IdentifierInfo *, 128> IIs;
     for (const auto &ID : PP.getIdentifierTable())
----------------
ributzka wrote:
> Would it make sense to reduce the size of the SmallVector too?
That would most likely regress serialization of real (non-scanning) PCMs, so I'd prefer to leave this be.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150494/new/
https://reviews.llvm.org/D150494
    
    
More information about the cfe-commits
mailing list