[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 11:31:16 PDT 2023


benlangmuir added inline comments.


================
Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43
 // CHECK-NEXT:               "context-hash": "{{.*}}",
-// CHECK-NEXT:               "module-name": "FW2_Private"
+// CHECK-NEXT:               "module-name": "FW2"
 // CHECK-NEXT:             }
----------------
Does this lose any test coverage for the FW2_Private case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150479/new/

https://reviews.llvm.org/D150479



More information about the cfe-commits mailing list