[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

Elliott Hughes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 10:59:30 PDT 2023


enh added a comment.

In D150490#4343128 <https://reviews.llvm.org/D150490#4343128>, @hiraditya wrote:

>> Is there more context on why Android enables the frame pointer?
>
> From what i gathered, this is more of an effort to have parity such that existing build flag overrides continue to be consistent.

well, when i said that on the internal chat, i thought you were asking "why do we say what clang already says?" :-)

if the question was actually "is there more context on why Android enables the frame pointer?" i'd have said something like "because Android developers [OS and app developers alike] do so much debugging from the field, where all we get is a crash report for something we probably can't repro locally, that having good _and_ cheap unwinds is super important to us".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150490/new/

https://reviews.llvm.org/D150490



More information about the cfe-commits mailing list