[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl
Vassil Vassilev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 15 09:02:56 PDT 2023
v.g.vassilev added a comment.
This is looking good. Can you address my minor comments and run clang-format?
================
Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1
+//===-------------- Offload.cpp - CUDA Offloading ---------------*- C++ -*-===//
+//
----------------
v.g.vassilev wrote:
> Likewise.
ping.
================
Comment at: clang/lib/Interpreter/DeviceOffload.h:1
+//===-------------- Offload.h - Device Offloading ---------------*- C++ -*-===//
+//
----------------
We should rename `Offload.h` to `DeviceOffload.h`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146389/new/
https://reviews.llvm.org/D146389
More information about the cfe-commits
mailing list