[PATCH] D150450: Add C++26 compile flags.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:456
+      // FIXME: Use correct value for C++26.
+      Builder.defineMacro("__cplusplus", "202402L");
+    else if (LangOpts.CPlusPlus23)
----------------
erichkeane wrote:
> aaron.ballman wrote:
> > This value is fine by me, but we should probably coordinate with the GCC folks so we don't wind up with two different values between us.
> Email sent to GCC maintainer (aaron copied!).
GCC is going to go with 202400L, so that is what we're going to do.


================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:456
+      // FIXME: Use correct value for C++26.
+      Builder.defineMacro("__cplusplus", "202102L");
+    // FIXME: Use correct value for C++23, and update C++26 to be 'one more'.
----------------
cor3ntin wrote:
> cor3ntin wrote:
> > erichkeane wrote:
> > > At the moment, I just chose '1 more than c++23', but that hasn't been set yet.  Once we have the final value, we should make this 1 more than 23's official value.
> > A value lesser than 202401L seems super confusing to me
> In the DIS __cplusplus is 202302L
GCC is going to go with 202400L, so that is what we're going to do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150450/new/

https://reviews.llvm.org/D150450