[PATCH] D147321: [RFC][Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 08:40:02 PDT 2023


jdoerfert added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5063
+  }
+}
+
----------------
Style `F`


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5063
+  }
+}
+
----------------
jdoerfert wrote:
> Style `F`
Why does this belong here? We should do it like clang, one function at a time, or in a generic place. This is not OpenMP specific at all.


================
Comment at: llvm/lib/IR/IRBuilder.cpp:1426
+}
+
 IRBuilderDefaultInserter::~IRBuilderDefaultInserter() = default;
----------------
No llvm::


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147321/new/

https://reviews.llvm.org/D147321



More information about the cfe-commits mailing list