[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign
Mikael Holmén via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 15 07:22:26 PDT 2023
uabelho added a comment.
In D149718#4342320 <https://reviews.llvm.org/D149718#4342320>, @Manna wrote:
> In D149718#4341384 <https://reviews.llvm.org/D149718#4341384>, @uabelho wrote:
>
>> In D149718#4341052 <https://reviews.llvm.org/D149718#4341052>, @uabelho wrote:
>>
>>> Compiling with clang 15.0.5 I get the following warning/error with this patch:
>>>
>>> ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
>>> AttributePool &operator=(AttributePool &&pool) = default;
>>> ^
>>> ../../clang/include/clang/Sema/ParsedAttr.h:674:21: note: move assignment operator of 'AttributePool' is implicitly deleted because field 'Factory' is of reference type 'clang::AttributeFactory &'
>>> AttributeFactory &Factory;
>>> ^
>>> 1 error generated.
>>
>> Also seen in this buildbot:
>> https://lab.llvm.org/buildbot/#/builders/214/builds/7476
>
> Thank you @uabelho for reporting. Build error is fixed by https://github.com/llvm/llvm-project/commit/292a6c1c2395f990bbde8d968825243e4fe9b954
Great, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149718/new/
https://reviews.llvm.org/D149718
More information about the cfe-commits
mailing list