[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 04:48:27 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D149276#4341552 <https://reviews.llvm.org/D149276#4341552>, @cor3ntin wrote:

> @aaron.ballman this won;t get approve by core un
>
> In D149276#4302700 <https://reviews.llvm.org/D149276#4302700>, @aaron.ballman wrote:
>
>> The changes generally LGTM, but:
>>
>>> in a way consistent with the proposed resolution to CWG1223.
>>
>> What are the chances that CWG changes their mind and picks a different direction?
>
> They were happy with the direction friday when we looked at it ( not the wording though). I think we should go ahead, waiting until after issaquah might be a bit too late (and if we are claiming auto(x) is implemented we should merge that in 17)

We don't have to wait for the wording to be final so long as the direction is in line with what you've done here, so LGTM! Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149276/new/

https://reviews.llvm.org/D149276



More information about the cfe-commits mailing list