[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 04:42:25 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.

In D149997#4338897 <https://reviews.llvm.org/D149997#4338897>, @mstorsjo wrote:

> Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda ugly way of checking for an MSVC-like environment specifically (when the MSVC mode is the exception compared with the rest), but neither `_MSC_VER` or `_MSC_EXTENSIONS` are defined by default in a `clang -cc1` invocation.

This seems like forward progress to me, so LG!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149997/new/

https://reviews.llvm.org/D149997



More information about the cfe-commits mailing list