[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

Aditya Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 12 16:14:13 PDT 2023


hiraditya added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424
+  if (Triple.isAndroid()) {
+    // AArch64 has frame pointers enabled for non-leaf functions.
+    switch (Triple.getArch()) {
----------------
hiraditya wrote:
> enh wrote:
> > (where? is it simpler to just add arm64 to the switch?)
> yeah we can add it for better readability but it would be redundant.
seems like we don't even have a test for aarch64.*android target. I'll add a testcase. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150490/new/

https://reviews.llvm.org/D150490



More information about the cfe-commits mailing list