[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

Elliott Hughes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 12 15:52:54 PDT 2023


enh added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424
+  if (Triple.isAndroid()) {
+    // AArch64 has frame pointers enabled for non-leaf functions.
+    switch (Triple.getArch()) {
----------------
(where? is it simpler to just add arm64 to the switch?)


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530
+                   Triple.isAArch64() || Triple.isPS() || Triple.isVE() ||
+                   (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64)));
   if (NoOmitFP || mustUseNonLeafFramePointerForTarget(Triple) ||
----------------
how does this work for Android/arm64?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150490/new/

https://reviews.llvm.org/D150490



More information about the cfe-commits mailing list