[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

[Elliott Hughes via Phabricator via cfe-commits]

enh added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:423
 
+  if (Triple.isAndroid() && Triple.getArch() == llvm::Triple::riscv64)
+    return true;
----------------
should this...


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:439
   case llvm::Triple::riscv32:
   case llvm::Triple::riscv64:
   case llvm::Triple::sparc:
----------------
(ah, this is why you need Android early. but, yeah, probably worth moving all the Android stuff together, like with the other OSes?)


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:459
       Triple.isOSHurd()) {
     switch (Triple.getArch()) {
     // Don't use a frame pointer on linux if optimizing for certain targets.
----------------
...be down here instead?


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:465
     case llvm::Triple::thumbeb:
       if (Triple.isAndroid())
         return true;
----------------
(take care of all this android/arm stuff where you take care of android/riscv64? arm64 has frame pointers by "default default", so we don't need to mention it?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150490/new/

https://reviews.llvm.org/D150490