[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl
Vassil Vassilev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 12 13:54:29 PDT 2023
v.g.vassilev added inline comments.
================
Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:39
const PreprocessorOptions &PreprocessorOpts; // Only used for debug info.
- const CodeGenOptions CodeGenOpts; // Intentionally copied in.
+ CodeGenOptions CodeGenOpts; // Intentionally copied in.
----------------
IIUC history correctly, here the intentional copy was to prevent some layering violation for what was called in 2009 `CompileOpts`. I believe that is not the case, can you check if we can take a const reference here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146389/new/
https://reviews.llvm.org/D146389
More information about the cfe-commits
mailing list