[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/ftime-trace.cpp:54
+// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3
+// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json" "-ftime-trace-granularity=0"
+// LINK3: -cc1{{.*}} "-ftime-trace=e/b-{{[^.]*}}.json" "-ftime-trace-granularity=0"
----------------
dyung wrote:
> This seems to be failing on Windows due to path separator issues:
> https://lab.llvm.org/buildbot/#/builders/216/builds/21115/steps/7/logs/FAIL__Clang__ftime-trace_cpp
> ```
> ... "-ftime-trace=e\\a-b9537d.json" ...
> ```
Sorry for the Windows breakage. d66417f0ae9d6b5e1be9b80c0c3630601169818d has fixed the issue: https://lab.llvm.org/buildbot/#/builders/216/builds/21121


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150282/new/

https://reviews.llvm.org/D150282