[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

Ziqing Luo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 12 11:43:15 PDT 2023


ziqingluo-90 marked an inline comment as done.
ziqingluo-90 added inline comments.


================
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2364
+                         Node->getBeginLoc())) {
+      UnsafeBufferUsageReporter R(S);
+      clang::checkUnsafeBufferUsage(Node, R, UnsafeBufferEmitFixits);
----------------
NoQ wrote:
> So WDYT about capturing the reporter from outside lambda instead?
The Reporter is stateless so we definitely can let analyses of functions share it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146342/new/

https://reviews.llvm.org/D146342



More information about the cfe-commits mailing list