[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added a comment.

In D150226#4336771 <https://reviews.llvm.org/D150226#4336771>, @manojgupta wrote:

> We also use Wno-enum-constexpr-conversion in ChromeOS. There are many packages that break with this warning. One of them is boost which is used in many other packages.
>
> The errors in boost were:
>
>   ./boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for this enumeration type [-Wenum-constexpr-conversion]
>   ./boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'
>   #   define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
>                                                 ^
>
> I do not think boost upstream has updated these files, I see they were last updated 3 years back.
> https://github.com/boostorg/mpl/blob/master/include/boost/mpl/aux_/static_cast.hpp
> and https://github.com/boostorg/mpl/blob/master/include/boost/mpl/aux_/integral_wrapper.hpp

I was under the impression from https://github.com/boostorg/mpl/issues/69 that this was fixed but there are a number of issues off of the main one and maybe I am confused.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150226/new/

https://reviews.llvm.org/D150226