[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1036
+  NormalizedValues<["Hostcall", "Buffered"]>,
+  MarshallingInfoEnum<LangOpts<"AMDGPUPrintfKindVal">, "Hostcall">;
 def fgpu_default_stream_EQ : Joined<["-"], "fgpu-default-stream=">,
----------------
as a target option, usually it starts with `-m` and does not contain target name, e.g. `-mprintf=`.

Better describe allowed values and their effect from users point of view, e.g. hostcall outputs immediately during kernel execution but requires some hardware feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150427/new/

https://reviews.llvm.org/D150427