[PATCH] D150364: [clang][Interp] Add 'Invalid' opcode and use it for throw/asm stmts

Fri May 12 07:21:35 PDT 2023

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang/test/AST/Interp/records.cpp:341
+
+    /// FIXME: Wrong source location below.
+    return 12; // expected-note {{in call to '&S{}->~S()'}}
----------------
tbaeder wrote:
> aaron.ballman wrote:
> > Oh interesting -- does the old constexpr interpreter think the destructor is called at the end of the block as opposed to at the end of the full expression with the temporary?
> I think it's the other way around and the new one does that (`expected` is the new one). Need to investigate that.
Ah oops, you're right, I did have that backwards. That makes more sense, thanks. :-)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150364/new/

https://reviews.llvm.org/D150364