[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

Andrew Gozillon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 11 19:00:45 PDT 2023


agozillon added a comment.

In the last commit I believe I addressed the last review comments and I added an OMPIRBuilderTest testing some of the functionality of the registerTargetGlobalVariable and getAddrOfDeclareTargetVar functionality! Just to maintain the standard of making tests for things added to the OMPIRBuilder (the functions are also tested rather profusely by Clang and LLVM already).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149162/new/

https://reviews.llvm.org/D149162



More information about the cfe-commits mailing list