[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

Hiroshi Yamauchi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 11 14:11:09 PDT 2023


yamauchi added a comment.

In D149800#4330831 <https://reviews.llvm.org/D149800#4330831>, @davidxl wrote:

> This patch uses a cleaner method than the previous effort. There is some differences:
>
> 1. yamauchi's patch works for both iFDO and autoFDO, while this patch limits to iFDO
> 2. yamauchi's patch also handles size optimization (IIRC) at granularity smaller than function
>
> Longer term, the previous functionality should fold into the new framework.

IIRC 1) and 2) are correct. I don't have a strong preference on which folds into which.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149800/new/

https://reviews.llvm.org/D149800



More information about the cfe-commits mailing list