[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 11 09:27:45 PDT 2023


tbaeder added a comment.

In D150364#4335221 <https://reviews.llvm.org/D150364#4335221>, @aaron.ballman wrote:

> "Unsupported" is a bit of a loaded term -- it could mean "this operation is not supported, YET" or it could mean "this operation is not and will not be supported, EVER". Perhaps something more like "InvalidInConstantExpr" would be more descriptive?

I guess it would be more descriptive, but it could still mean that it is "not yet valid in a constant expression", so I guess I don't see the upside of using a longer opcode name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150364/new/

https://reviews.llvm.org/D150364



More information about the cfe-commits mailing list