[PATCH] D150320: [clang][deps] Avoid relocatable modules checks

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 10 15:51:53 PDT 2023


benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.

With my naming comment addressed, LGTM



================
Comment at: clang/include/clang/Lex/PreprocessorOptions.h:73
+  /// Perform extra checks for relocatable modules when loading PCM files.
+  bool RelocatableModules = true;
+
----------------
Suggestion: `CheckRelocatableModules`.  The current name sounds like a compiler feature rather than controlling diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150320/new/

https://reviews.llvm.org/D150320



More information about the cfe-commits mailing list