[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 10 15:21:58 PDT 2023


jansvoboda11 created this revision.
jansvoboda11 added reviewers: benlangmuir, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Adding new field into the scanning service and propagating it down into the worker, action or collector requires a lot of boilerplate and causes conflicts in our downstream repo. Fix this by passing around the whole service object.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150318

Files:
  clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h
  clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h
  clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h
  clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
  clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150318.521120.patch
Type: text/x-patch
Size: 10867 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230510/fac7e8d1/attachment-0001.bin>


More information about the cfe-commits mailing list