[PATCH] D150209: [clang][Interp] Add more shift error checking

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 10 13:35:43 PDT 2023


shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/AST/Interp/Interp.h:141-142
+
+  // C++2a [expr.shift]p2: E1 << E2 is the unique value congruent to
+  // E1 x 2^E2 module 2^N.
+
----------------
Just adding a reference to https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0907r4.html since that is the paper that changed this behavior


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150209/new/

https://reviews.llvm.org/D150209



More information about the cfe-commits mailing list