[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

Tue May 9 12:40:42 PDT 2023

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D149193#4328553 <https://reviews.llvm.org/D149193#4328553>, @MaskRay wrote:

> In D149193#4328452 <https://reviews.llvm.org/D149193#4328452>, @dblaikie wrote:
>
>>> I agree that for most(all?) split DWARF users will not see any difference since they always use -c -o and don't combine compilation and linking in one command.
>>
>> Given that, I'm not sure that this is worth implementing, but if it suits you I guess.
>
> The split DWARF users are about production users.
>
> There are command line users who do `clang -g -gsplit-dwarf a.c b.c -o x` and I have heard about questions that the `.dwo` files go to strange directories (usually `/tmp`) quite a few times.
> Fixing `-gsplit-dwarf` helps set a baseline for other options like `-ftime-trace` (https://github.com/llvm/llvm-project/issues/57285).

Fair enough

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149193/new/

https://reviews.llvm.org/D149193