[clang-tools-extra] 28bdff1 - [clangd][NFX][FIX] Fix conflicting symbol name `Expr`

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Tue May 9 05:58:59 PDT 2023


Author: Joseph Huber
Date: 2023-05-09T07:58:36-05:00
New Revision: 28bdff19e3ad981ef83e372e8c301f1407b82135

URL: https://github.com/llvm/llvm-project/commit/28bdff19e3ad981ef83e372e8c301f1407b82135
DIFF: https://github.com/llvm/llvm-project/commit/28bdff19e3ad981ef83e372e8c301f1407b82135.diff

LOG: [clangd][NFX][FIX] Fix conflicting symbol name `Expr`

Summary:
This class has a member named `Expr` which conflicts with the clang type
of the same name due to the namespace. If we want to do this we need to
explicitly scope the variable. This was preventing me from building.
This was introduced in https://reviews.llvm.org/D148457

Added: 
    

Modified: 
    clang-tools-extra/clangd/Hover.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp
index 9b789901e77c..61bed1ad8141 100644
--- a/clang-tools-extra/clangd/Hover.cpp
+++ b/clang-tools-extra/clangd/Hover.cpp
@@ -468,7 +468,7 @@ struct PrintExprResult {
   std::optional<std::string> PrintedValue;
   /// The Expr object that represents the closest evaluable
   /// expression.
-  const Expr *Expr;
+  const clang::Expr *Expr;
   /// The node of selection tree where the traversal stops.
   const SelectionTree::Node *Node;
 };


        


More information about the cfe-commits mailing list