[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

[Vassil Vassilev via Phabricator via cfe-commits]

v.g.vassilev added a comment.

Generally lgtm, let's extend the test coverage.



================
Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1
+//===-------------- Offload.cpp - CUDA Offloading ---------------*- C++ -*-===//
+//
----------------
Likewise.


================
Comment at: clang/lib/Interpreter/DeviceOffload.h:1
+//===--------------- Offload.h - CUDA Offloading ----------------*- C++ -*-===//
+//
----------------
We should probably update the name here as well and maybe drop CUDA?


================
Comment at: clang/test/Interpreter/CUDA/sanity.cu:10
+// CHECK: CUDA Error: 0
+
+%quit
----------------
Let's extend the coverage with some more standard hello world examples. We can draw some inspiration from https://github.com/root-project/cling/tree/master/test/CUDADeviceCode


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146389/new/

https://reviews.llvm.org/D146389