[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

Qingyuan Zheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 8 22:59:10 PDT 2023


daiyousei-qz added a comment.

Sorry, I'm a little occupied lately and don't have time to fix the test failure. I'll try to fix that in this week.



================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:400
+  bool ActiveKindLookup[static_cast<size_t>(HighlightingKind::LastKind) + 1];
+  uint32_t ActiveModifiersMask;
+};
----------------
nridge wrote:
> For good measure, let's `static_assert(HighlightingModifier::LastModifier < 32)`
IIRC, we already have such static_assert after the definition of HighlightingModifier in SemanticHighlight.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148489/new/

https://reviews.llvm.org/D148489



More information about the cfe-commits mailing list