[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

[Wang Pengcheng via Phabricator via cfe-commits]

pcwang-thead added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td:15
+class SiFive7IsWorstCaseMX<string mx, list<string> MxList> {
+  string LLMUL = LargestLMUL<MxList>.r;
+  bit c = !eq(mx, LLMUL);
----------------
I think I have fixed the issue that `defar` can't refer to template arguments in D148197. So `LMUL`, `SSEW` and other fields can be replaced with `defvar`s.


================
Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:41
 
+// Helper function to get the largest LMUL from MxList
+// Precondition: MxList is sorted in ascending LMUL order.
----------------
So, are we going to discard `LMULXXXImpl` below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149495/new/

https://reviews.llvm.org/D149495