[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added a comment.

We have several new build failures with this change that I'm looking through. So far, a common one is an error of the form

  /source/module.modulemap: error: redefinition of module
  /build/Foo.framework/Modules/module.modulemap: note: previously defined here

ie. we're now finding the same module in two places where we didn't before. It's possible we could avoid this for framework modules if we ignore framework modules that are not actually in framework directories, but we have seen this with non-frameworks modules as well.

Another class of errors is where the module we find does not compile in the current context, or it doesn't provide what the includer wanted when built as a module. Basically we silently depended on it being a textual include.

Still looking at issues and not sure whether these are blockers or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103930/new/

https://reviews.llvm.org/D103930