[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 8 14:52:15 PDT 2023


rnk added a subscriber: hans.
rnk added a comment.

This feels to me like we are still working around some incompatibilities between the MSVC intrin.h / intrin0.h model. I would prefer it if we could always use `static inline` consistently in our intrinsic headers so we don't have to worry about ODR violation problems. However, we're using always_inline so there's not much to worry about anyway.

Anyway, if it comes up again, we should try to come up with a better fix. + at hans


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139749/new/

https://reviews.llvm.org/D139749



More information about the cfe-commits mailing list