[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594
 
+    if (DiscardResult)
+      return true;
+
----------------
aaron.ballman wrote:
> For my own understanding -- why do we not need to call `discard()` on the operand expression?
Is it ever legal to have an argument expr with side effects (in cases the constant expression interpreter needs to handle)? That's really the only reason I did it this way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149965/new/

https://reviews.llvm.org/D149965