[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

Mon May 8 08:34:37 PDT 2023

cor3ntin added a comment.

In D150038#4326576 <https://reviews.llvm.org/D150038#4326576>, @aaron.ballman wrote:

> In D150038#4326554 <https://reviews.llvm.org/D150038#4326554>, @cor3ntin wrote:
>
>> In D150038#4326549 <https://reviews.llvm.org/D150038#4326549>, @aaron.ballman wrote:
>>
>>> Do you have some performance measurement numbers for how much benefit we get from the changes?
>>
>> Not really.
>> The PR that changed the scope of trailing return type had a 0.35% regression, I expect this to be in the same ballpark in the other direction
>> http://llvm-compile-time-tracker.com/compare.php?from=cd173cbd7cca69c29df42cd4b42e60433435c29b&to=d708a186b6a9b050d09558163dd353d9f738c82d&stat=instructions%3Au
>
> We usually want performance-related changes to come with some hard measurements because of how painfully easy it is to think something will result in a positive performance change that ends up being a wash. Would you mind putting a branch up on the compile time tracker page to validate your expectations? .35% better performance would be nice to see!

Ask and you shall receive http://llvm-compile-time-tracker.com/?remote=cor3ntin

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150038/new/

https://reviews.llvm.org/D150038