[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 8 06:20:19 PDT 2023


erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

Give folks another 48 hrs to disagree, but this seems fine to me/consistent with other comments.



================
Comment at: clang/lib/Sema/SemaDecl.cpp:1824
 
-static bool isUsingDecl(NamedDecl *D) {
+static bool isUsingDeclAtClassScope(NamedDecl *D) {
+  if (D->getDeclContext()->isFileContext())
----------------
ChuanqiXu wrote:
> This is the ad-hoc change. Look at the following comment.
So this name isn't really what you're doing. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148506/new/

https://reviews.llvm.org/D148506



More information about the cfe-commits mailing list