[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:15357
 
-  if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSideEffects)
-    return false;
+  {
+    FullExpressionRAII Scope(Info);
----------------
Can you add a comment explaining why this is necessary, I don't see it myself. Maybe a quote from the standard if it is applicable as well.

Also the description of the PR should be more descriptive even if it is mostly a copy past of your comment from the bug report.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150036/new/

https://reviews.llvm.org/D150036