[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 6 06:17:43 PDT 2023


tbaeder added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:15356-15360
 
-  if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSideEffects)
+  FullExpressionRAII Scope(Info);
+  if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSideEffects  || !Scope.destroy())
     return false;
 
----------------
Makes more sense, I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150036/new/

https://reviews.llvm.org/D150036



More information about the cfe-commits mailing list