[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

Fri May 5 16:07:53 PDT 2023

barannikov88 added a comment.

In D149978#4323457 <https://reviews.llvm.org/D149978#4323457>, @jhuber6 wrote:

> In D149978#4323452 <https://reviews.llvm.org/D149978#4323452>, @tra wrote:
>
>>> I've discovered that LLVM adds -Wl,-fcolor-diagnostics
>>
>> Can you tell me where it's done?
>
> `llvm/cmake/modules/HandleLLVMOptions.cmake:994`

This might have to do something with

  # Handle common options used by all runtimes.
  include(AddLLVM)

in `runtimes/CMakeLists.txt`

which is totally wrong in my opinion.
In a standalone build (not sure about runtimes build) AddLLVM determines flags for building LLVM itself, not for building runtime libraries.
The results of the tests of the //host// toolchain therefore affect the invocation of the //target// toolchain.
I came across this once in https://reviews.llvm.org/D146920#4240370

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149978/new/

https://reviews.llvm.org/D149978