[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 5 14:53:24 PDT 2023


tra added a comment.

> The latter is a little difficult,

The more we dig, the more we want GPU-capable lld. :-)



================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:641
+      // by nvlink.
+      if (llvm::any_of(II.getInputArg().getValues(), [](StringRef Arg) {
+            return Arg.equals("--color-diagnostics");
----------------
Can there ever be more than one value returned by `II.getInputArg().getValues()`?

If so, we probably don't want to skip all of them if one of them is `--color-diagnostics`. We may want to ignore only singleton `--color-diagnostics` and let all other combinations error out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149978/new/

https://reviews.llvm.org/D149978



More information about the cfe-commits mailing list