[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC
Min-Yih Hsu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 5 09:51:25 PDT 2023
myhsu added inline comments.
================
Comment at: clang/test/CodeGen/mrtd.c:9
+// X86: define{{.*}} x86_stdcallcc void @foo(i32 noundef %arg) [[NUW:#[0-9]+]]
+// M68k: define{{.*}} cc104 void @foo(i32 noundef %arg)
void foo(int arg) {
----------------
0x59616e wrote:
> 0x59616e wrote:
> > Just curious, why do we have to use such an arcane name instead of a more lucid one , such as `m68k_rtdcc`.
> I guess this involves more work ?
> I guess this involves more work ?
Yes because it requires changes to (LLVM IR's) AsmReader/Writer. But it's not hard and I can do that. The reason I didn't do that was simply because this CC is rare so the arcane name's impact on (our) productivity will be low.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149867/new/
https://reviews.llvm.org/D149867
More information about the cfe-commits
mailing list