[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

Sergei Barannikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 19:27:39 PDT 2023


barannikov88 added a comment.

In D148092#4317438 <https://reviews.llvm.org/D148092#4317438>, @efriedma wrote:

> Is there some alternative way we can write this?  Even if each of the overrides is only technically used in one place, it's a repeating pattern, and writing the casts inline makes it really hard to read.  (Maybe the helpers can be somewhere else?)

Thanks for the suggestion. Does it look better now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148092/new/

https://reviews.llvm.org/D148092



More information about the cfe-commits mailing list